Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: handle quoting in service file, too. #15880

Merged
merged 1 commit into from Aug 16, 2023
Merged

service: handle quoting in service file, too. #15880

merged 1 commit into from Aug 16, 2023

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid mentioned this pull request Aug 16, 2023
Merged
carlocab
carlocab approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how service files handle shell quotes, but it seems to me that they should behave the way we expect (right?).

@MikeMcQuaid
Copy link
Member Author

Not sure how service files handle shell quotes, but it seems to me that they should behave the way we expect (right?).

It seems so. If they don't: I guess we just drop back to the original approach in #15875 of doing quoting only when there's spaces in the argument.

@MikeMcQuaid MikeMcQuaid merged commit e475de2 into Homebrew:master Aug 16, 2023
24 checks passed
@MikeMcQuaid MikeMcQuaid deleted the more_service_quoting branch August 16, 2023 13:34
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

@SMillerDev SMillerDev Awaiting requested review from SMillerDev

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeMcQuaid @carlocab