Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Version: Improve date version parsing" #16083

Merged
merged 1 commit into from Oct 4, 2023
Merged

Revert "Version: Improve date version parsing" #16083

merged 1 commit into from Oct 4, 2023

Conversation

fxcoudert
Copy link
Member

@fxcoudert fxcoudert commented Oct 4, 2023 •
edited

This reverts commit 7626bdd.

See discussion in #16081

@fxcoudert fxcoudert marked this pull request as ready for review October 4, 2023 17:57
@iMichka iMichka added the critical Critical change which should be shipped as soon as possible. label Oct 4, 2023
@fxcoudert fxcoudert requested a review from samford October 4, 2023 17:58
samford
samford approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Version change isn't pressing by any means, so reverting until we can sort out the release situation makes sense 👍

@fxcoudert fxcoudert mentioned this pull request Oct 4, 2023
Merged
6 tasks
@MikeMcQuaid MikeMcQuaid merged commit ec5ad35 into Homebrew:master Oct 4, 2023
28 checks passed
@fxcoudert fxcoudert deleted the revert branch October 4, 2023 18:30
@samford samford mentioned this pull request Oct 4, 2023
Merged
7 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samford samford samford approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@iMichka iMichka iMichka approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fxcoudert @samford @BrewTestBot @iMichka @MikeMcQuaid