Add missing permissions to actions publish

[jameelkaisar]

This commit enhances the publish actions script by including a step to close the pull request after
committing the changes. The existing script deletes the branch after pushing the commits, but lacks
the functionality to close the associated PR.

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Permissions Added:

• contents: write
• pull-requests: write

See: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

[Bo98]

brew pr-pull should already handle this without needing any extra permissions by modifying the commit message:

brew/Library/Homebrew/dev-cmd/pr-pull.rb

Lines 98 to 103 in 5349b76

	close_message = "Closes ##{pull_request}."
	body += "\n\n#{close_message}" unless body.include? close_message
	end
	git_args = Utils::Git.git, "-C", git_repo.pathname, "commit", "--amend", "--signoff", "--allow-empty", "--quiet",
	"--message", subject, "--message", body, "--message", trailers

[jameelkaisar]

@Bo98 Yes, you are right, it is already been handled but I was getting some errors while testing this. The errors were due to missing permissions.

[Bo98]

Ah ok that makes more sense. So did you find that you could do just the permission changes without the gh pr close change?

[jameelkaisar]

I looked into it and found out that the 'contents: write' permission is required to publish releases and the 'pull-requests: write' permission is required to close the pull request after the changes are committed. It seems like mentioning these permissions explicitly was not required in the past but now it is required.

See: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

[Bo98]

Makes sense. Thanks!

[carlocab]

Thanks!

[MikeMcQuaid]

Nice work everyone!

[jameelkaisar]

Thanks 😊