Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/pr-upload: fix gems not being installed with --upload-only #16144

Merged
merged 1 commit into from Oct 26, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Oct 26, 2023

Gem install was incorrectly inside the unless args.upload_only? block.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Oct 26, 2023
@Bo98 Bo98 enabled auto-merge October 26, 2023 19:25
@Bo98 Bo98 merged commit ce63b7c into Homebrew:master Oct 26, 2023
28 checks passed
@Bo98 Bo98 deleted the pr-upload-gem-fix branch October 26, 2023 19:38
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants