cmd/update.sh: don't switch to master when updating to a tag #16283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues seen with the
homebrew/brew:latest
image where it doesn't have thestable
branch setup so it does a detached 4.1.22 -> master -> stable. This PR avoids that intermediate master change by making that pull happen in the background to the working state.The issues with
homebrew/brew:latest
will be fixed anyway with 4.1.23 when the vendored gems become a part of the tag, but this change is still worthwhile to prevent that class of issues in the future as downgrades generally don't work well withgit
and vendored gems. The checkout is also unnecessary I/O as we checkout stable immediately afterwards.I will also look into fixing the branches in the Dockerfile (i.e. run
brew update
somewhere), which will also avoid the issue.