Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops/cask: add a cop for specific numbered shared file list files #16581

Merged
merged 3 commits into from Feb 10, 2024

Conversation

bevanjkay
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Adds a rubocop to replace shared file list files in zap trash arrays with a glob (*) instead, as the version number can change between systems and MacOS versions.

Old issue explaining: Homebrew/homebrew-cask#40557

This action is often completed manually by maintainers, or at intervals in a systematic fashion.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks again @bevanjkay!

Co-authored-by: Kevin <apainintheneck@gmail.com>
@apainintheneck apainintheneck merged commit 0782ba1 into Homebrew:master Feb 10, 2024
24 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants