Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail if superfluous packages are excluded #16603

Merged

Conversation

SMillerDev
Copy link
Member

@SMillerDev SMillerDev commented Feb 6, 2024

Fixes issue where:

  • you add a package and depend on the six formula so you add it to the exclude list
  • upstream removes the dependency on six in a new release
  • everything keeps depending on six since currently we have no way to know if the excludes list has superfluous entries.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a bit more context for what's happening here? What's a superfluous package and why is excluding one fatal?

@SMillerDev
Copy link
Member Author

So the thing I'm trying to fix is:

  • you add a package and depend on the six formula so you add it to the exclude list
  • upstream removes the dependency on six in a new release
  • everything keeps depending on six since currently we have no way to know if the excludes list has superfluous entries.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for elaborating! Have put your explanation into the PR body so it'll be in a merge commit. One suggestion and then, when CI fixed, can approve and merge 👍🏻

Library/Homebrew/utils/pypi.rb Outdated Show resolved Hide resolved
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@SMillerDev SMillerDev merged commit 71123a0 into Homebrew:master Feb 12, 2024
24 checks passed
@SMillerDev SMillerDev deleted the fix/pypy_bump/fail_superfluous_excludes branch February 12, 2024 15:48
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants