New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include all test paths in RSpec cops #16642
Conversation
7e66f4c
to
e98d352
Compare
let(:path_with_tilde) { Pathname.new("#{dir}/path_with_tilde") } | ||
let(:glob_path1) { Pathname.new("#{dir}/glob_path1") } | ||
let(:glob_path2) { Pathname.new("#{dir}/glob_path2") } | ||
let(:paths) { [absolute_path, path_with_tilde, glob_path1, glob_path2] } | ||
let(:glob_path) { Pathname.new("#{dir}/glob_path") } | ||
let(:glob_path_) { Pathname.new("#{dir}/glob_path_") } | ||
let(:paths) { [absolute_path, path_with_tilde, glob_path, glob_path_] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one doesn't make that much sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open to alternatives, just trying to obey the letter and not the spirit of the cop. 😈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glob_path_alt
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open to alternatives, just trying to obey the letter and not the spirit of the cop. 😈
🤣
glob_path_alt
?
That's a bit better. I'm fine with that.
e98d352
to
12d32cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks again @dduugg!
I think that'd be nice! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Per docs:
(Possibly, we want to follow convention and rename the
test
dir tospec
, but we'd still have to apply the fixes here)