Move tapioca args to config; exclude unnecessary gems

[dduugg]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Moving tapioca args to a config both simplifies code and allows for using tapioca tooling outside of the typecheck command. I also noticed we're compiling a bunch of gems that aren't being used in ruby. Excluding them doesn't noticeably speed up typecheck updates (because nearly all the time is spent compiling a single gem, parser, for reasons i haven't yet debugged), so this may be viewed as an unnecessary optimization (though it does reduce the lines of code checked in by >10%). This wasn't an exhaustive search, so folks may find more gems that could be added to the list.

[reitermarkus]

doesn't noticeably speed up typecheck updates

Given this, I think this will just result in more work needed to keep this exclude list updated and correct.

[apainintheneck]

Maybe there's some way to automatically audit this to make sure it's up-to-date. Removing 60k lines from the codebase seems useful too.

[dduugg]

I added a test that validates the list of exclusions are all actual dependencies. (Though, I don't feel too strongly about greatly expanding the list here, should folks still have reservations.)

[reitermarkus]

I'm not too worried about excluding things that aren't dependencies anymore. I'm more concerned about excluding dependencies that become needed for some reason. Is there an automatic way to determine whether a dependency “is needed”?

[dduugg]

I can imagine a brew typecheck feature that can identify an incorrect exclude, based on the namespace of a type error, but that's probably more trouble than it's worth.

I've asked in the #tapioca channel of the sorbet slack to see if excluding unreferenced dependencies is something other folks bother with, I will update if I hear anything back.

[MikeMcQuaid]

I use this list on another project and: it becomes pretty obvious when things are needed because brew typecheck will fail until RBI files are added.

[MikeMcQuaid]

Thanks @dduugg!

[MikeMcQuaid]

I use this list on another project and: it becomes pretty obvious when things are needed because brew typecheck will fail until RBI files are added.