utils/pypi: default to formula version when using package_name #16771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?When using
package_name
, we currently end up dropping the version information. For example,vs. removing
package_name
:This can potentially lead to incorrect resolution if the formula version is not the latest version.
With change, the default version is obtained from the formula:
One potential issue is if the formula version scheme is different from PyPI formula scheme.
If we hit this and there is no other solution, then I think we could add a way of bypassing this inside
pypi_formula_mappings.json
(e.g. an extra field likeunversioned: true
orwithout_version: true
or some other name)