Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS::Mac::CPU: add Apple Silicon #7793

Merged
merged 1 commit into from Jun 22, 2020

Conversation

mistydemeo
Copy link
Member

@mistydemeo mistydemeo commented Jun 22, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Apple's existing CPU_TYPE_ARM64 define, used on iOS, also represents ARM64 on Mac.

@mistydemeo mistydemeo force-pushed the add_apple_silicon branch 3 times, most recently from 72fb531 to 3bb5cff Compare June 22, 2020 19:17
Co-authored-by: Shaun Jackman <sjackman@gmail.com>
Copy link
Member

@sjackman sjackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! (and scary)

@mistydemeo mistydemeo merged commit c1a23fc into Homebrew:master Jun 22, 2020
@mistydemeo mistydemeo deleted the add_apple_silicon branch June 22, 2020 19:51
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 28, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants