Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install: permit ARM-based Macs #7794

Merged
merged 1 commit into from Jun 22, 2020

Conversation

mistydemeo
Copy link
Member

@mistydemeo mistydemeo commented Jun 22, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

ARM Macs exist now! We need to permit those too.

Copy link
Member

@sjackman sjackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this Linux-specific function:

def check_cpu
return if (Hardware::CPU.intel? && Hardware::CPU.is_64_bit?) || Hardware::CPU.arm?
message = "Sorry, Homebrew does not support your computer's CPU architecture!"
if Hardware::CPU.ppc64le?
message += <<~EOS
For OpenPOWER Linux (PPC64LE) support, see:
#{Formatter.url("https://github.com/homebrew-ppc64le/brew")}
EOS
end
abort message
end

@mistydemeo
Copy link
Member Author

The Linux specific function has different messaging. If I delete it, it will point PPC64 Linux users at Tigerbrew instead.

Copy link
Member

@sjackman sjackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Linux specific function has different messaging. If I delete it, it will point PPC64 Linux users at Tigerbrew instead.

Woops! I missed that.

@mistydemeo mistydemeo merged commit 9cd0166 into Homebrew:master Jun 22, 2020
@mistydemeo mistydemeo deleted the permit_arm_macs branch June 22, 2020 20:54
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 27, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants