Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move .codecov.yml #7895

Merged
merged 1 commit into from Jul 3, 2020
Merged

Move .codecov.yml #7895

merged 1 commit into from Jul 3, 2020

Conversation

MikeMcQuaid
Copy link
Member

the file must still be located in the root, dev/, or .github/ directories

https://docs.codecov.io/docs/codecov-yaml#can-i-name-the-file-codecovyml

CC @Bo98

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid MikeMcQuaid mentioned this pull request Jul 3, 2020
6 tasks
@MikeMcQuaid
Copy link
Member Author

@Bo98 Does this still look like it's not working to you?

@Bo98
Copy link
Member

Bo98 commented Jul 3, 2020

Well this PR shouldn't be red, but I have no idea whether it correctly takes codecov.yml files in PRs or not - it might still be looking at master.

@Bo98
Copy link
Member

Bo98 commented Jul 3, 2020

https://docs.codecov.io/docs/codecov-yaml

Codecov will use the default branch for your repository as the "master" copy of the repositories Codecov Yaml.

I don't know what "master copy" means but ok

The default branch is used to identify:

  1. Which branch to cache the repository yaml for UI changes.

I also don't know what that means

Codecov will always use the current yaml on the branch being tested by default.

I guess it isn't working?

@Bo98
Copy link
Member

Bo98 commented Jul 3, 2020

cat .github/codecov.yml | curl --data-binary @- https://codecov.io/validate

Wrong keys 'coverage', 'fixes' in {'fixes': ['::Library/Homebrew/'], 'coverage': {'round': 'nearest', 'status': {'project': {'default': {'threshold': '0.05%'}}}}}

Removing the parent codecov key in the yml file fixes this.

>  the file must still be located in the root, dev/, or .github/ directories

https://docs.codecov.io/docs/codecov-yaml#can-i-name-the-file-codecovyml
@MikeMcQuaid
Copy link
Member Author

@Bo98 Thanks, good catch, updated.

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me that it's working now.

@Bo98 Bo98 merged commit 505c1e7 into Homebrew:master Jul 3, 2020
@MikeMcQuaid MikeMcQuaid deleted the move-codecov branch July 3, 2020 18:17
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 26, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants