Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language/python: allow python@3.7 to be used for virtualenvs #7959

Merged
merged 2 commits into from Jul 9, 2020
Merged

language/python: allow python@3.7 to be used for virtualenvs #7959

merged 2 commits into from Jul 9, 2020

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Jul 9, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@Rylan12 Rylan12 mentioned this pull request Jul 9, 2020
Closed
MikeMcQuaid
MikeMcQuaid reviewed Jul 9, 2020
View reviewed changes
Library/Homebrew/exceptions.rb
cannot be guessed automatically because a recognised Python dependency could not be found.

If you are using a non-standard Python depedency, please add `:using => "python@x.y"` to
`virtualenv_install_with_resources` to resolve the issue manually.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Rylan12
Copy link
Member

Rylan12 commented Jul 9, 2020 •
edited

Is it worth changing this to accept any python dependency without hardcoding an allowlist?

i.e. check for any python@ dependency instead of only python@3.7 or python@3.8

It gives us one less thing to change when python@3.7 is removed or python@3.9 is added

@Bo98
Copy link
Member Author

Bo98 commented Jul 9, 2020 •
edited

Yes, it is definitely worth doing that.

I might opt to do that after the brew release today (I don't want to set up too many road blocks) unless you all prefer for me to do it now.

@MikeMcQuaid
Copy link
Member

👍 to holding off for now so we can land this PR and get a release out ASAP.

@Rylan12
Copy link
Member

Rylan12 commented Jul 9, 2020

👍 totally agree

@Bo98 Bo98 merged commit 04370d4 into Homebrew:master Jul 9, 2020
@Bo98 Bo98 deleted the python3.7 branch July 9, 2020 15:44
@petetnt petetnt mentioned this pull request Oct 1, 2020
Closed
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bo98 @Rylan12 @MikeMcQuaid @BrewTestBot