Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemfile: set sorbet version #8055

Merged
merged 3 commits into from Jul 21, 2020
Merged

Conversation

vidusheeamoli
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The new Sorbet release introduced 100+ new errors which we'll be dealing with after we have more files transitioned to true in sorbet/files.yaml. Hence, this PR sets Sorbet to the version that we're working on currently.

@vidusheeamoli
Copy link
Contributor Author

cc @issyl0 @mistydemeo

Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@issyl0
Copy link
Member

issyl0 commented Jul 21, 2020

Worth noting that the new errors Sorbet brings are in Tapioca's autogenerated gem RBI files, so I'm not sure there's much we can do. I've been keeping an eye out for new Tapioca and Sorbet versions, but 🤷.

@issyl0 issyl0 merged commit ee648ef into Homebrew:master Jul 21, 2020
@vidusheeamoli vidusheeamoli deleted the set-sorbet-version branch July 22, 2020 17:48
@issyl0 issyl0 added the gsoc-outreachy Google Summer of Code or Outreachy label Jul 31, 2020
@issyl0 issyl0 mentioned this pull request Aug 9, 2020
6 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 21, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gsoc-outreachy Google Summer of Code or Outreachy outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants