New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pr-upload: fix formula version #8129

Merged

jonchang merged 1 commit into master from pr-upload-fix

Jul 29, 2020

Member

dawidd6 commented Jul 29, 2020

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew style with your changes locally?
Have you successfully run brew tests with your changes locally?

https://github.com/Homebrew/homebrew-core/runs/922157314?check_suite_focus=true

Error: Bottles are for spdlog 1.7.0_1 but formula is version 1.7.0!


          pr-upload: fix formula version

3ee158b

dawidd6 requested a review from jonchang

July 29, 2020 07:23

jonchang approved these changes

View reviewed changes

Contributor

jonchang left a comment

Thanks for this fix!

jonchang merged commit 7713e92 into master

jonchang deleted the pr-upload-fix branch

July 29, 2020 07:54

BrewTestBot added the outdated label

Homebrew locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.