Skip to content

pr-upload: fix formula version#8129

Merged
jonchang merged 1 commit intomasterfrom
pr-upload-fix
Jul 29, 2020
Merged

pr-upload: fix formula version#8129
jonchang merged 1 commit intomasterfrom
pr-upload-fix

Conversation

@dawidd6
Copy link
Copy Markdown
Contributor

@dawidd6 dawidd6 commented Jul 29, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

https://github.com/Homebrew/homebrew-core/runs/922157314?check_suite_focus=true

Error: Bottles are for spdlog 1.7.0_1 but formula is version 1.7.0!

@dawidd6 dawidd6 requested a review from jonchang July 29, 2020 07:23
Copy link
Copy Markdown
Contributor

@jonchang jonchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@jonchang jonchang merged commit 7713e92 into master Jul 29, 2020
@jonchang jonchang deleted the pr-upload-fix branch July 29, 2020 07:54
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 21, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants