Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-upload: use PkgVersion.parse instead of Version.new #8133

Merged
merged 1 commit into from Jul 29, 2020
Merged

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Jul 29, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Error: Bottles are for spdlog 1.7.0_1 but formula is version 1.7.0_1!

@dawidd6 dawidd6 requested review from jonchang and samford July 29, 2020 09:11
@dawidd6 dawidd6 marked this pull request as draft July 29, 2020 09:15
@jonchang
Copy link
Contributor

Looks like I messed up in the last PR and forgot about PkgVersion:

> PkgVersion.parse "1.7.0_1"
=> #<PkgVersion:0x00007fd16411a188 @version=#<Version:0x00007fd16411a1b0 @version="1.7.0">, @revision=1>
> Version.new "1.7.0_1"
=> #<Version:0x00007fd1651fa840 @version="1.7.0_1">

Changing it should fix the problem once and for all...

@dawidd6 dawidd6 changed the title pr-upload: compare stringified versions pr-upload: use PkgVersion.parse instead of Version.new Jul 29, 2020
@dawidd6 dawidd6 marked this pull request as ready for review July 29, 2020 09:19
Copy link
Contributor

@jonchang jonchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this works but as the Bintray API is down the --online test is failing, and until it comes back up it actually doesn't matter if this is merged or not 🤷

@jonchang jonchang merged commit 28554db into master Jul 29, 2020
@jonchang jonchang deleted the another-fix branch July 29, 2020 10:13
@jonchang
Copy link
Contributor

Thanks @dawidd6 !

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 21, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants