Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop.yml: cask fixes for new style #8140

Merged
merged 1 commit into from Jul 31, 2020
Merged

Conversation

miccal
Copy link
Member

@miccal miccal commented Jul 30, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

There are a handful of casks in the cask-versions, cask-drivers and cask-fonts repositories that are failing because of the Line is too long error in brew cask style.

I have added a few more cases to IgnoredPatterns: which should alleviate the vast majority of them (all but one, I think).

Ping @reitermarkus, @vitorgalvao, @ran-dall and @core-code.

Thank you.

@vitorgalvao
Copy link
Member

I’ve noticed the errors as well. Thank you for the fix. Why '#{language}', '#{version.' though? Wouldn’t it make sense to just do it for the stanzas where those appear?

Pinging @MikeMcQuaid as well.

@miccal
Copy link
Member Author

miccal commented Jul 30, 2020

@vitorgalvao '#{version.' was already there, and will catch this one.

'#{language}' will catch this one, for example.

Out of all the currently failing casks, I think these changes (and the two open PR's I have for cask-versions) will fix them all but one.

@MikeMcQuaid
Copy link
Member

I'm game for some of these but the ideal case (particularly with lower numbers of casks) would be to fix the long lines where possible.

@miccal
Copy link
Member Author

miccal commented Jul 30, 2020

@MikeMcQuaid there are several ways to break up a string across multiple lines in Ruby -- which was would you suggest for, say, line 16 of this cask?

@MikeMcQuaid
Copy link
Member

@miccal I'd say

"SomeVeryLongString" \
"ContinuedOnANewLine"

@miccal
Copy link
Member Author

miccal commented Jul 30, 2020

Thanks -- so, which parts of IgnoredPatterns: are you happy to stay, and which parts would you like to see removed?

@MikeMcQuaid
Copy link
Member

Thanks -- so, which parts of IgnoredPatterns: are you happy to stay, and which parts would you like to see removed?

I defer to you given the above! I'm fine as-is if you are.

@miccal
Copy link
Member Author

miccal commented Jul 30, 2020

Thanks (as always) -- I think my additions will fix > 99 % of cases that may be encountered in the cask repo's.

@vitorgalvao vitorgalvao merged commit a7276ad into Homebrew:master Jul 31, 2020
@miccal miccal deleted the caskstyle branch July 31, 2020 00:54
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 21, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants