New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rubocop.yml: cask fixes for new style #8140
Conversation
I’ve noticed the errors as well. Thank you for the fix. Why Pinging @MikeMcQuaid as well. |
@vitorgalvao
Out of all the currently failing casks, I think these changes (and the two open PR's I have for |
I'm game for some of these but the ideal case (particularly with lower numbers of casks) would be to fix the long lines where possible. |
@MikeMcQuaid there are several ways to break up a string across multiple lines in Ruby -- which was would you suggest for, say, line 16 of this cask? |
@miccal I'd say "SomeVeryLongString" \
"ContinuedOnANewLine" |
Thanks -- so, which parts of |
I defer to you given the above! I'm fine as-is if you are. |
Thanks (as always) -- I think my additions will fix > 99 % of cases that may be encountered in the cask repo's. |
brew style
with your changes locally?brew tests
with your changes locally?There are a handful of casks in the
cask-versions
,cask-drivers
andcask-fonts
repositories that are failing because of theLine is too long
error inbrew cask style
.I have added a few more cases to
IgnoredPatterns:
which should alleviate the vast majority of them (all but one, I think).Ping @reitermarkus, @vitorgalvao, @ran-dall and @core-code.
Thank you.