patchelf.rb reading for everyone :)

[rmNULL]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

enable patchelf.rb reading for everyone.

Those who don't wish to use patchelf.rb can do so by
exporting HOMEBREW_NO_PATCHELF_RB=1 to their env.

[rmNULL]

cc @sjackman @woodruffw @MikeMcQuaid

[MikeMcQuaid]

Not experimental any more. Let's just remove all usage of HOMEBREW_PATCHELF_RB and HOMEBREW_NO_PATCHELF_RB and delete the legacy code. We can revert this PR if we need to turn it off after that.

[woodruffw]

Agreed with this; could you make these changes @rmNULL?

[woodruffw]

CI failure looks unrelated:

1st Try error in ./test/cmd/services_spec.rb:4:
expected block to output "Warning: No services available to control with brew services\n" to stderr, but output "Warning: Calling Homebrew.args is deprecated! Use args = <command>_args.parse and pass args along the call chain instead.\nPlease report this issue to the homebrew/services tap (not Homebrew/brew or Homebrew/core), or even better, submit a PR to fix it:\n /private/tmp/homebrew-tests-20200808-15182-19bc5zq/prefix/Library/Taps/homebrew/homebrew-services/lib/services_cli.rb:65\n\nWarning: No services available to control with brew services\n"

[MikeMcQuaid]

Thanks @rmNULL!