Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order and grouping of cask stanzas #8265

Merged

Conversation

waldyrious
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I found some inconsistencies when I started preparing the documentation update after #8137. This PR makes the following changes:

  • Put desc stanza after the name stanza (I mistakenly introduced it to the wrong array position in Add a desc stanza to the cask DSL #8137)
  • Add missing language stanza to its own group, as shown here.
    • I also adjusted the test that used this stanza, to conform to the stanzas within the same group should have no lines between them rule.
  • Add missing vst3_plugin stanza to the group containing vst_plugin, as shown here

Should there also be a target stanza here, according to this?

@waldyrious
Copy link
Contributor Author

I see from the failing tests that the existing casks that use the language stanza fail the same brew style issue that I had to address in test/support/fixtures/cask/Casks/with-languages.rb. I can think of some ways to address this:

  • Edit the casks in Homebrew/homebrew-cask to remove the blank line between language blocks
  • Make an exception for the language stanza in the stanzas within the same group should have no lines between them rule.
  • Keep the language stanza out of the sorting/grouping validation (as it was before)
  • Something else

How should I proceed?

@reitermarkus reitermarkus added the cask Homebrew Cask label Aug 9, 2020
@reitermarkus reitermarkus requested a review from a team August 9, 2020 15:07
@reitermarkus
Copy link
Member

Please open a separate PR for the language stanza order so we can merge the fix for desc.

Should there also be a target stanza here

No, that's an attribute for the artifact stanza.

- Put `desc` stanza after the `name` stanza
- Add missing `vst3_plugin` stanza to the group containing `vst_plugin`
@waldyrious waldyrious force-pushed the fix-cask-stanza-order-and-grouping branch from c464fae to 1b71d99 Compare August 9, 2020 17:28
@reitermarkus reitermarkus merged commit 984e926 into Homebrew:master Aug 9, 2020
@reitermarkus
Copy link
Member

Thanks, @waldyrious!

@waldyrious waldyrious deleted the fix-cask-stanza-order-and-grouping branch August 11, 2020 19:42
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 18, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cask Homebrew Cask outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants