Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list: Replace Cask::Cmd with class method #8290

Merged
merged 1 commit into from Aug 11, 2020
Merged

list: Replace Cask::Cmd with class method #8290

merged 1 commit into from Aug 11, 2020

Conversation

whoiswillma
Copy link
Member

@whoiswillma whoiswillma commented Aug 10, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

In the same vein as #8214, replace usage of Cask::Cmd::List with a class method, and call that class method directly.

@whoiswillma whoiswillma marked this pull request as ready for review August 10, 2020 20:33
@reitermarkus reitermarkus merged commit b447f57 into Homebrew:master Aug 11, 2020
@reitermarkus
Copy link
Member

Thanks, @whoiswillma!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 19, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants