Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improve @-versioned formulae linking." #9016

Merged
merged 1 commit into from Oct 30, 2020

Conversation

sjackman
Copy link
Member

@sjackman sjackman commented Oct 30, 2020

Reverts #9009

==> brew audit --tap=brewsci/bio
Error: 2 problems in 2 formulae detected
brewsci/bio/seqan@2:
  * Formula has other versions so create a versioned alias:
      cd /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/brewsci/homebrew-bio/Aliases
      ln -s ../Formula/seqan@2.rb seqan@2@2
brewsci/bio/seqan@3:
  * Formula has other versions so create a versioned alias:
      cd /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/brewsci/homebrew-bio/Aliases
      ln -s ../Formula/seqan@3.rb seqan@3@3
==> FAILED

https://github.com/brewsci/homebrew-bio/pull/1184/checks?check_run_id=1333247048#step:4:74

We’ll that’s a strange error message.

@MikeMcQuaid PR #9009 appears to have broken brew audit.

@sjackman sjackman added the bug Reproducible Homebrew/brew bug label Oct 30, 2020
@sjackman
Copy link
Member Author

This issue appears to affect only third-party taps due to to this if:

def audit_file
if formula.core_formula? && @versioned_formula

@sjackman
Copy link
Member Author

$ brew audit brewsci/bio/seqan@3
brewsci/bio/seqan@3:
  * Formula has other versions so create a versioned alias:
      cd /usr/local/Homebrew/Library/Taps/brewsci/homebrew-bio/Aliases
      ln -s ../Formula/seqan@3.rb seqan@3@3
Error: 1 problem in 1 formula detected
$ git switch revert-9009-improve-versioned-linking
Branch 'revert-9009-improve-versioned-linking' set up to track remote branch 'revert-9009-improve-versioned-linking' from 'origin'.
Switched to a new branch 'revert-9009-improve-versioned-linking'
$ brew audit brewsci/bio/seqan@3 && echo good
good

@sjackman sjackman merged commit 45b81db into master Oct 30, 2020
@sjackman sjackman deleted the revert-9009-improve-versioned-linking branch October 30, 2020 18:13
MikeMcQuaid added a commit that referenced this pull request Nov 2, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Reproducible Homebrew/brew bug outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants