Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language/node: remove unneeded scripts prior to installation #9048

Merged
merged 3 commits into from Nov 6, 2020
Merged

language/node: remove unneeded scripts prior to installation #9048

merged 3 commits into from Nov 6, 2020

Conversation

dtrodrigues
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Based on discussion in Homebrew/homebrew-core#63798, this removes the prepare and prepack scripts from package.json prior to calling npm pack.

Resolves Homebrew/homebrew-core#63798.

The linked failed Homebrew/core PRs successfully install after this change.

cc @chrmoritz @zachauten

zachauten
zachauten approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@zachauten zachauten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

MikeMcQuaid
MikeMcQuaid reviewed Nov 5, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on here @dtrodrigues!

Library/Homebrew/language/node.rb Outdated Show resolved Hide resolved
Library/Homebrew/language/node.rb Outdated Show resolved Hide resolved
Library/Homebrew/language/node.rb Outdated Show resolved Hide resolved
@dtrodrigues dtrodrigues mentioned this pull request Nov 5, 2020
Closed
MikeMcQuaid
MikeMcQuaid approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit and then 👍🏻 to 🚢. Nice work @dtrodrigues!

Library/Homebrew/language/node.rb Outdated Show resolved Hide resolved
@dtrodrigues @MikeMcQuaid
Update Library/Homebrew/language/node.rb
f9a15e7 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@dtrodrigues dtrodrigues merged commit 0f3c4b1 into Homebrew:master Nov 6, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@zachauten zachauten zachauten approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--ignore-scripts no longer works for "npm pack"
4 participants
@dtrodrigues @MikeMcQuaid @zachauten @BrewTestBot