-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
language/node: remove unneeded scripts prior to installation #9048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on here @dtrodrigues!
b5f2e74
to
2f6f30b
Compare
2f6f30b
to
bd1869d
Compare
bd1869d
to
027419e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny nit and then 👍🏻 to 🚢. Nice work @dtrodrigues!
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
brew style
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?Based on discussion in Homebrew/homebrew-core#63798, this removes the
prepare
andprepack
scripts frompackage.json
prior to callingnpm pack
.Resolves Homebrew/homebrew-core#63798.
The linked failed Homebrew/core PRs successfully install after this change.
cc @chrmoritz @zachauten