bottle: fix adding bottle block to formulae with special license

[SeekingMeaning]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?
• Have you successfully run brew man locally and committed any changes?

---

This adds support for license symbols (e.g.:cannot_represent) and hashes (e.g. "MIT" => { ... }) to the brew bottle command

1. [^\[]+?\[[^\]]+?\] matches any_of: ["MIT", "0BSD"]
2. [^{]+?{[^}]+?} matches "MIT" => { with: "LLVM-exception" }
3. :\S+ matches :public_domain

Related:

• bottle commit breaks audit #9080
• xterm 361 (new formula) homebrew-core#64303
• xterm: move bottle block homebrew-core#64349

[fxcoudert]

How about license any_of: and license all_of:? I'm not sure from the regexp that these are handled.

I am also seeing some other weird things in some homebrew-core formulas:

• license = "MIT" in nim: is that legal?
• many formulas have arrays, without any_of or all_of, commented out like this in libical:

# license ["LGPL-2.1", "MPL-2.0"] - pending https://github.com/Homebrew/brew/pull/7953

[SeekingMeaning]

How about license any_of: and license all_of:? I'm not sure from the regexp that these are handled.

They are; [^\[]+? matches any_of: and all_of: (this includes trailing spaces after the colon)

Although, expressions such as "MIT" => { with: "LLVM-exception" } don't appear to be supported

• license = "MIT" in nim: is that legal?

I don't think so

• many formulas have arrays, without any_of or all_of, commented out like this in libical

Those need to be updated (Homebrew/homebrew-core#58225 (comment))

[Rylan12]

I don't think this handles multiline licenses:

  license all_of: [
    :public_domain,
    "MIT",
    "GPL-3.0-or-later" => { with: "Autoconf-exception-3.0" },
  ]

[SeekingMeaning]

I thought the same too but it turns out that the regex is actually multiline: https://github.com/Homebrew/brew/blob/50ce5ef/Library/Homebrew/dev-cmd/bottle.rb#L548

[MikeMcQuaid]

Thanks @SeekingMeaning! This will really need to be rewritten to use a proper Ruby parser at some point to stop it 💥ing so often.