bottle commit breaks audit

[fxcoudert]

This bottle commit: Homebrew/homebrew-core@b786f28
inserted the bottle block in the wrong place, breaking audit (for all PRs in homebrew-core)

• There is a testbot issue, clearly
• Can we find a way not to audit style of formulas unrelated to the PR in homebrew-core? This has happened several times recently, and one formula is blocking progress on all homebrew-core

[MikeMcQuaid]

• Can we find a way not to audit style of formulas unrelated to the PR in homebrew-core? This has happened several times recently, and one formula is blocking progress on all homebrew-core

This is needed to avoid the situation where we end up breaking Homebrew/homebrew-core's audits and not noticing. It's good that this stops progress because it should: we do not want to introduce audit (i.e. CI) regressions.

[MikeMcQuaid]

Have opened #9089 to prevent this happening in future by running brew audit before upload.

[fxcoudert]

Thanks @MikeMcQuaid, I should have been more clear: I don't think we should enforce audits that haven't already been enforced earlier. I.e., these should not be primary checks, but only secondary checks (because they should not normally fail).

[MikeMcQuaid]

I don't think we should enforce audits that haven't already been enforced earlier. I.e., these should not be primary checks, but only secondary checks (because they should not normally fail).

Sorry, I don't understand the point here. What should/shouldn't be enforced?

I worked pretty hard to ensure that brew style and brew audit are passing for all of Homebrew/homebrew-core. They should be mandatory checks on Homebrew/brew and Homebrew/homebrew-core to avoid them being broken again.

[fxcoudert]

I meant that #9089 is a crucial piece to ensure this sort of thing does not happen again. Need more coffee before I type.

[MikeMcQuaid]

@fxcoudert Gotcha, we're agreed 🎉