Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livecheck: skip disabled formulae #9112

Merged
merged 1 commit into from Nov 14, 2020
Merged

livecheck: skip disabled formulae #9112

merged 1 commit into from Nov 14, 2020

Conversation

samford
Copy link
Member

@samford samford commented Nov 11, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This PR modifies brew livecheck to automatically skip disabled formulae which don't contain a livecheck block. We already do this for deprecated and versioned formulae without a livecheck block, so this is a logical extension.

@samford samford merged commit c5fea1b into Homebrew:master Nov 14, 2020
@samford samford deleted the livecheck-skip-disabled-formulae branch November 14, 2020 03:57
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants