Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/Installation.md: Fix a small typo #9121

Merged
merged 1 commit into from Nov 12, 2020
Merged

docs/Installation.md: Fix a small typo #9121

merged 1 commit into from Nov 12, 2020

Conversation

sjackman
Copy link
Member

@sjackman sjackman commented Nov 12, 2020 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Fix a small typo in docs/Installation.md.

@request-info
Copy link

request-info bot commented Nov 12, 2020

Please provide a better issue/pull request title and/or description!

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Nov 12, 2020
@sjackman sjackman self-assigned this Nov 12, 2020
@sjackman sjackman removed the needs response Needs a response from the issue/PR author label Nov 12, 2020
MikeMcQuaid
MikeMcQuaid approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for the fix!

issyl0
issyl0 approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably the lack of an Oxford comma isn't a typo, but in this case along with the leading / in /home/linuxbrew/.linuxbrew, I agree, so I'll let you have it. 😆

@sjackman sjackman merged commit c3e82f6 into Homebrew:master Nov 12, 2020
@sjackman sjackman deleted the sj/docs-installation branch November 12, 2020 21:04
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@issyl0 issyl0 issyl0 approved these changes

Assignees

@sjackman sjackman

Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sjackman @MikeMcQuaid @issyl0 @BrewTestBot