New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os/linux.rb: don't show codename when it's n/a #9353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review period will end on 2020-12-01 at 20:51:04 UTC. |
BrewTestBot
added
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Nov 30, 2020
maxim-belkin
force-pushed
the
config-no-codename
branch
from
November 30, 2020 22:17
7dd95aa
to
a84a5fc
Compare
MikeMcQuaid
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me but will need rebased before CI is 🟢
maxim-belkin
force-pushed
the
config-no-codename
branch
from
December 1, 2020 16:36
a84a5fc
to
4d672d1
Compare
rebased |
MikeMcQuaid
reviewed
Dec 1, 2020
BrewTestBot
removed
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Dec 1, 2020
Review period ended. |
BrewTestBot
approved these changes
Dec 1, 2020
Thanks @maxim-belkin! |
Thanks, Maxim! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?Some Linux distros don't have codenames, so
lsb_release -c
returnsn/a
.brew config
shows the OS that Homebrew detects and adds OS codename in parentheses. It can be somewhat confusing when codename is equal ton/a
:Here I'm changing the output of
os_version
function so that we don't show codename when it'sn/a
. Also, instead of using outputs oflsb_release -d
andlsb_release -c
separately, I'm callinglsb_release
with-a
flag to get all the information in one step and then parse the output to obtain the required information.