Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: migrate some lists back to Homebrew/brew #9397

Merged
merged 3 commits into from Dec 3, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Dec 3, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This PR moves the lists for the ProvidedByMacos and UsesFromMacos cops back to Homebrew/brew. As pointed out by @MikeMcQuaid in Homebrew/homebrew-core#65927 (comment), these are not tap-specific and so they should still live in Homebrew/brew.

A few notes:

  • I still left the ability for a third-party tap to add their own exceptions to these lists in. Let me know if these should be removed.
  • I readded the formula exist check to ensure that tests will fail if any of these formulae are removed from Homebrew-core. This existed as a shared_example before, so I readded it in the same way since the check is performed in two separate _spec files.

I'm marking this PR as critical because removing these lists caused unintended breakage for some formulae in third-party taps as reported in Homebrew/homebrew-core#65927 (comment).

@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Dec 3, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 3, 2020

Review period ended.

@MikeMcQuaid
Copy link
Member

  • I still left the ability for a third-party tap to add their own exceptions to these lists in. Let me know if these should be removed.

Yeh, I think so 👍🏻 (but can be a follow-up PR).

  • I readded the formula exist check to ensure that tests will fail if any of these formulae are removed from Homebrew-core. This existed as a shared_example before, so I readded it in the same way since the check is performed in two separate _spec files.

Thanks 👍🏻

Merging as-is to fix the tap breaking. Thanks for the quick turnaround as usual @Rylan12!

@MikeMcQuaid MikeMcQuaid merged commit 48af3b2 into Homebrew:master Dec 3, 2020
@Rylan12 Rylan12 deleted the readd-macos-lists branch December 3, 2020 14:31
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 3, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants