style: migrate some lists back to Homebrew/brew #9397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?This PR moves the lists for the
ProvidedByMacos
andUsesFromMacos
cops back to Homebrew/brew. As pointed out by @MikeMcQuaid in Homebrew/homebrew-core#65927 (comment), these are not tap-specific and so they should still live in Homebrew/brew.A few notes:
formula exist
check to ensure thattests
will fail if any of these formulae are removed from Homebrew-core. This existed as ashared_example
before, so I readded it in the same way since the check is performed in two separate_spec
files.I'm marking this PR as
critical
because removing these lists caused unintended breakage for some formulae in third-party taps as reported in Homebrew/homebrew-core#65927 (comment).