[Library/Homebrew/cli/named_args.rb] to_formulae_to_casks(): Reasssociate its rescue Block with the Correct Enclosing Scope
#9431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ciate its
`rescue` block with the right enclosing scope.
PR Homebrew#9398 accidentally removed some semantically significant indentation in
this function, thus inadvertently kicking the `rescue` block inside out to func-
tion scope, when it moved its code further up in the file. This may well not
confuse a Ruby interpreter, but it could trip human readers up. Compensate and
correct the overlooked offending oversight and potential refactoring mistake by
restoring only that indentation, leaving the function in its new location.
Refs Homebrew#9398.
reitermarkus
approved these changes
Dec 6, 2020
|
Thanks! Apparently RuboCop doesn't catch this. |
|
No problem! |
RandomDSdevel
deleted the
restore-semantically-significant-indentation-lost-accidentally-in-PR-9398
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally? (No unexpected failures or new failures related to my changes other than some test execution timeouts due to running on older hardware.)brew manlocally and committed any changes?I noticed a small issue with PR #9398; this PR fixes it.
CC @reitermarkus. (Let me know if you actually meant to make the change I revert here.)