New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on_macos/on_linux block: improve rubocop message #9486
on_macos/on_linux block: improve rubocop message #9486
Conversation
Review period will end on 2020-12-10 at 17:05:22 UTC. |
Here are the tests in question: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/test/rubocops/components_order_spec.rb#L388-L412
Our best available options, I think:
|
I found you can abbreviate the message with |
Another bug I found: If the block only contains one node which isn't allowed, it will not catch it since I guess the whole cop only applies if there are multiple components in the block. |
I'm not quite sure why this is even part of |
#9470 fixes this |
Review period ended. |
Co-authored-by: Markus Reiter <me@reitermark.us>
270b662
to
c4da302
Compare
brew style
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?Related: #9470 (comment)
Changes:
Before:
After: