Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brew upgrade ignores --dry-run option #10909

Closed
1 task done
kidonng opened this issue Mar 22, 2021 · 1 comment · Fixed by #10910
Closed
1 task done

brew upgrade ignores --dry-run option #10909

kidonng opened this issue Mar 22, 2021 · 1 comment · Fixed by #10910
Assignees
@Bo98
Labels
bug Reproducible Homebrew/brew bug outdated PR was locked due to age

Comments

@kidonng
Copy link
Contributor

kidonng commented Mar 22, 2021 •
edited

brew config output

HOMEBREW_VERSION: 3.0.8-12-g28b1765
ORIGIN: https://github.com/Homebrew/brew
HEAD: 28b176567992f8d323d73a0a1367d8239e34e8a4
Last commit: 42 minutes ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 76f9b4a0c3d48200edd075343103b24c8bebe53c
Core tap last commit: 19 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_BOTTLE_DOMAIN: https://mirrors.ustc.edu.cn/homebrew-bottles
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: nvim
HOMEBREW_MAKE_JOBS: 8
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: octa-core 64-bit kabylake
Clang: 12.0 build 1200
Git: 2.31.0 => /usr/local/bin/git
Curl: 7.64.1 => /usr/bin/curl
macOS: 11.3-x86_64
CLT: 12.0.32.29
Xcode: N/A

brew doctor output

Your system is ready to brew.

  • The brew doctor above contains no "Warning" lines.

What were you trying to do (and why)?

Checking outdated formulae and casks by brew upgrade --greedy --dry-run.

What happened (include all command output)?

Homebrew starts to upgrade packages.

What did you expect to happen?

Homebrew should not do upgrades with --dry-run.

Step-by-step reproduction instructions (by running brew commands)

1. Have at least one outdated formula
2. Run `brew upgrade --dry-run`

This is introduced in #10880:

image

(EDIT last screenshot is wrong)
@kidonng kidonng added the bug Reproducible Homebrew/brew bug label Mar 22, 2021
@carlocab
Copy link
Member

#10907 might help, but I suspect @Bo98 should have a fix for this shortly.

Bo98 added a commit to Bo98/brew that referenced this issue Mar 22, 2021
@Bo98
cmd/upgrade: fix --dry-run
3bf38a1 
Fixes Homebrew#10909.
@Bo98 Bo98 mentioned this issue Mar 22, 2021
Merged
7 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Bo98 Bo98

Labels
bug Reproducible Homebrew/brew bug outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/upgrade: fix --dry-run Bo98/brew
3 participants
@Bo98 @carlocab @kidonng