Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only suggest adding livecheck if auto-detection fails. #11050

Merged
merged 1 commit into from Apr 7, 2021
Merged

Only suggest adding livecheck if auto-detection fails. #11050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions Library/Homebrew/cask/audit.rb
View file
Open in desktop
Expand Up @@ -316,6 +316,7 @@ def check_hosting_with_livecheck(livecheck_result:)
case cask.url.to_s
when %r{sourceforge.net/(\S+)}
return if cask.version.latest?
return unless online?

add_error "Download is hosted on SourceForge, #{add_livecheck}"
when %r{dl.devmate.com/(\S+)}
Expand Down
1 change: 1 addition & 0 deletions Library/Homebrew/test/cask/audit_spec.rb
View file
Open in desktop
Expand Up @@ -630,6 +630,7 @@ def tmp_cask(name, text)

context "when the download is hosted on SourceForge and does not have a livecheck" do
let(:cask_token) { "sourceforge-correct-url-format" }
let(:online) { true }

it { is_expected.to fail_with(message) }
end
Expand Down