Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate path args to audit cmd #14285

Merged
merged 1 commit into from Dec 27, 2022
Merged

Deprecate path args to audit cmd #14285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions Library/Homebrew/dev-cmd/audit.rb
View file
Open in desktop
Expand Up @@ -140,6 +140,11 @@ def audit
no_named_args = true
[Formula.all, Cask::Cask.all]
else
if args.named.any? { |named_arg| named_arg.end_with?(".rb") }
odeprecated "brew audit [path ...]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, for future reference we normally don't add deprecations before major or minor releases. Can either comment this out for now or just leave it if no-one else cares.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say let's keep it and revert if we get a single complaint/issue

Copy link
Member

@p-linnane p-linnane Dec 27, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing failures on homebrew-cask CI: https://github.com/Homebrew/homebrew-cask/actions/runs/3789525755/jobs/6443372033

EDIT: Homebrew/homebrew-cask#138591

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might be a good reason to comment this out for now. I wouldn't be surprised if other cask taps have copied our CI configuration to an extent, and if we're seeing errors they may be too. I'm also okay waiting to hear if anyone actually opens an issue, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry, I didn't realize that. I think it makes sense to comment it out for now. I assume this is was only failing for us because we set HOMEBREW_DEVELOPER, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI config specifically passes the path to audit. I just updated it to use token instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened up #14295 to comment out the deprecation until a future release.

"brew audit [name ...]"
end

args.named.to_formulae_and_casks
.partition { |formula_or_cask| formula_or_cask.is_a?(Formula) }
end
Expand Down