-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubocop: 0.50.0 and Ruby 2.3 #3183
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -163,7 +163,7 @@ def elisp_caveats | |
|
||
def plist_caveats | ||
s = [] | ||
if f.plist || (keg && keg.plist_installed?) | ||
if f.plist || (keg&.plist_installed?) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are the parentheses still needed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed. |
||
plist_domain = f.plist_path.basename(".plist") | ||
|
||
# we readlink because this path probably doesn't exist since caveats | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,7 +55,7 @@ def prune | |
else | ||
n, d = ObserverPathnameExtension.counts | ||
print "Pruned #{n} symbolic links " | ||
print "and #{d} directories " if d > 0 | ||
print "and #{d} directories " if d.positive? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh how gross. can we opt out of this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use Python? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you first |
||
puts "from #{HOMEBREW_PREFIX}" | ||
end | ||
end | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# frozen_string_literal: true | ||
|
||
# RuboCop version used for `brew style` and `brew cask style` | ||
HOMEBREW_RUBOCOP_VERSION = "0.49.1".freeze | ||
HOMEBREW_RUBOCOP_CASK_VERSION = "~> 0.13.1".freeze # has to be updated when RuboCop version changes | ||
HOMEBREW_RUBOCOP_VERSION = "0.50.0" | ||
HOMEBREW_RUBOCOP_CASK_VERSION = "~> 0.14.2" # has to be updated when RuboCop version changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. My
$EDITOR
's Rubocop plugin has already been driving me up the wall overEOS
stuff.Edit - Up the wall, not up to the wall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can thank me for the fit I pitched about it lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what the issue is with
EOS
to be honest. It'd seem silly to get ultra-specific inside formulae at least.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubocop/rubocop#4467
I get the sense that whatever conversations there were about this didn't really occur in the open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nice thing is that in TextMate you get nested syntax highlighting inside heredocs if you use e.g.
RUBY
, but if it's just text, I'm also in favour ofEOS
.