Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: support & use aggressive caching #4774

Merged
merged 3 commits into from
Aug 30, 2018
Merged

go: support & use aggressive caching #4774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4598995
formula: always set GOCACHE
DomT4 Aug 29, 2018
318eb50
cleanup: cleanup go_cache
DomT4 Aug 29, 2018
b333f7a
cleanup_spec: test go_cache cleanup
DomT4 Aug 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Library/Homebrew/cleanup.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def incomplete?
end

def nested_cache?
directory? && %w[glide_home java_cache npm_cache gclient_cache].include?(basename.to_s)
directory? && %w[go_cache glide_home java_cache npm_cache gclient_cache].include?(basename.to_s)
end

def prune?(days)
Expand Down
2 changes: 2 additions & 0 deletions Library/Homebrew/formula.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1678,6 +1678,7 @@ def run_test
PATH: PATH.new(ENV["PATH"], HOMEBREW_PREFIX/"bin"),
HOMEBREW_PATH: nil,
_JAVA_OPTIONS: "#{ENV["_JAVA_OPTIONS"]} -Duser.home=#{HOMEBREW_CACHE}/java_cache",
GOCACHE: "#{HOMEBREW_CACHE}/go_cache",
}

ENV.clear_sensitive_environment!
Expand Down Expand Up @@ -2029,6 +2030,7 @@ def stage
stage_env[:HOME] = env_home
stage_env[:_JAVA_OPTIONS] =
"#{ENV["_JAVA_OPTIONS"]} -Duser.home=#{HOMEBREW_CACHE}/java_cache"
stage_env[:GOCACHE] = "#{HOMEBREW_CACHE}/go_cache"
stage_env[:CURL_HOME] = ENV["CURL_HOME"] || ENV["HOME"]
end

Expand Down
9 changes: 9 additions & 0 deletions Library/Homebrew/test/cleanup_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,15 @@
expect(incomplete).not_to exist
end

it "cleans up 'go_cache'" do
go_cache = (HOMEBREW_CACHE/"go_cache")
go_cache.mkpath

subject.cleanup_cache

expect(go_cache).not_to exist
end

it "cleans up 'glide_home'" do
glide_home = (HOMEBREW_CACHE/"glide_home")
glide_home.mkpath
Expand Down