Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry all specs with :needs_network. #4901

Merged
merged 1 commit into from
Sep 14, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Library/Homebrew/test/cmd/search_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
.and be_a_success
end

it "falls back to a GitHub tap search when no formula is found", :needs_network, retry: 3 do
it "falls back to a GitHub tap search when no formula is found", :needs_network do
setup_remote_tap "homebrew/cask"

expect { brew "search", "homebrew/cask/firefox" }
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/test/cmd/services_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
describe "brew services", :integration_test, :needs_macos, :needs_network, retry: 3 do
describe "brew services", :integration_test, :needs_macos, :needs_network do
it "allows controlling services" do
setup_remote_tap "homebrew/services"

Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/test/dev-cmd/pull_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
describe "brew pull", :integration_test do
it "fetches a patch from a GitHub commit or pull request and applies it", :needs_network, retry: 3 do
it "fetches a patch from a GitHub commit or pull request and applies it", :needs_network do
CoreTap.instance.path.cd do
system "git", "init"
system "git", "checkout", "-b", "new-branch"
Expand Down
4 changes: 4 additions & 0 deletions Library/Homebrew/test/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@
skip "Requires network connection." unless ENV["HOMEBREW_TEST_ONLINE"]
end

config.around(:each, :needs_network) do |example|
example.run_with_retry retry: 3, retry_wait: 1
end

config.before(:each, :needs_svn) do
skip "subversion not installed." unless which "svn"
end
Expand Down