Run tests with HOMEBREW_DEVELOPER unset.

Library/Homebrew/brew.rb

@@ -51,8 +51,10 @@
       internal_dev_cmd = require? HOMEBREW_LIBRARY_PATH/"dev-cmd"/cmd
       internal_cmd = internal_dev_cmd
       if internal_dev_cmd && !ARGV.homebrew_developer?
-        system "git", "config", "--file=#{HOMEBREW_REPOSITORY}/.git/config",
-                                "--replace-all", "homebrew.devcmdrun", "true"
+        if (HOMEBREW_REPOSITORY/".git/config").exist?
+          system "git", "config", "--file=#{HOMEBREW_REPOSITORY}/.git/config",
+                                  "--replace-all", "homebrew.devcmdrun", "true"
+        end
         ENV["HOMEBREW_DEV_CMD_RUN"] = "1"
       end
     end

Library/Homebrew/dev-cmd/tests.rb

@@ -43,8 +43,8 @@ def tests
       ENV.delete("HOMEBREW_TEMP")
       ENV.delete("HOMEBREW_NO_GITHUB_API")
       ENV.delete("HOMEBREW_NO_EMOJI")
+      ENV.delete("HOMEBREW_DEVELOPER")
       ENV["HOMEBREW_NO_ANALYTICS_THIS_RUN"] = "1"
-      ENV["HOMEBREW_DEVELOPER"] = "1"
       ENV["HOMEBREW_NO_COMPAT"] = "1" if args.no_compat?
       ENV["HOMEBREW_TEST_GENERIC_OS"] = "1" if args.generic?
       ENV["HOMEBREW_TEST_ONLINE"] = "1" if args.online?

Library/Homebrew/test/cmd/uninstall_spec.rb

@@ -42,6 +42,8 @@
 
   describe "::handle_unsatisfied_dependents" do
     specify "when developer" do
+      ENV["HOMEBREW_DEVELOPER"] = "1"
+
       expect {
         described_class.handle_unsatisfied_dependents(opts)
       }.to output(/Warning/).to_stderr
@@ -50,25 +52,21 @@
     end
 
     specify "when not developer" do
-      run_as_not_developer do
-        expect {
-          described_class.handle_unsatisfied_dependents(opts)
-        }.to output(/Error/).to_stderr
+      expect {
+        described_class.handle_unsatisfied_dependents(opts)
+      }.to output(/Error/).to_stderr
 
-        expect(described_class).to have_failed
-      end
+      expect(described_class).to have_failed
     end
 
     specify "when not developer and --ignore-dependencies is specified" do
       ARGV << "--ignore-dependencies"
 
-      run_as_not_developer do
-        expect {
-          described_class.handle_unsatisfied_dependents(opts)
-        }.not_to output.to_stderr
+      expect {
+        described_class.handle_unsatisfied_dependents(opts)
+      }.not_to output.to_stderr
 
-        expect(described_class).not_to have_failed
-      end
+      expect(described_class).not_to have_failed
     end
   end
 end

Library/Homebrew/test/formula_installer_spec.rb

@@ -150,4 +150,15 @@ class #{Formulary.class_s(dep_name)} < Formula
       temporary_install(Failball.new)
     }.to raise_error(RuntimeError)
   end
+
+  describe "#caveats" do
+    subject(:formula_installer) { described_class.new(Testball.new) }
+
+    it "shows audit problems if HOMEBREW_DEVELOPER is set" do
+      ENV["HOMEBREW_DEVELOPER"] = "1"
+      formula_installer.install
+      expect(formula_installer).to receive(:audit_installed).and_call_original
+      formula_installer.caveats
+    end
+  end
 end

Library/Homebrew/test/utils_spec.rb

@@ -118,18 +118,6 @@ def esc(code)
     end
   end
 
-  describe "#run_as_not_developer" do
-    it "temporarily unsets HOMEBREW_DEVELOPER" do
-      ENV["HOMEBREW_DEVELOPER"] = "foo"
-
-      run_as_not_developer do
-        expect(ENV["HOMEBREW_DEVELOPER"]).to be nil
-      end
-
-      expect(ENV["HOMEBREW_DEVELOPER"]).to eq("foo")
-    end
-  end
-
   describe "#which" do
     let(:cmd) { dir/"foo" }
 

Library/Homebrew/utils.rb

@@ -296,12 +296,6 @@ def with_custom_locale(locale)
   end
 end
 
-def run_as_not_developer
-  with_env(HOMEBREW_DEVELOPER: nil) do
-    yield
-  end
-end
-
 # Kernel.system but with exceptions
 def safe_system(cmd, *args, **options)
   return if Homebrew.system(cmd, *args, **options)