Remove the accessibility_access stanza.

Library/Homebrew/cask/cask.rb

@@ -135,7 +135,6 @@ def to_h
         "depends_on" => depends_on,
         "conflicts_with" => conflicts_with.to_a,
         "container" => container,
-        "accessibility_access" => accessibility_access,
         "auto_updates" => auto_updates,
       }
     end

Library/Homebrew/cask/cmd/upgrade.rb

@@ -83,8 +83,6 @@ def run
             new_cask_installer.install_artifacts
             new_artifacts_installed = true
 
-            new_cask_installer.enable_accessibility_access
-
             # If successful, wipe the old Cask from staging
             old_cask_installer.finalize_upgrade
           rescue CaskError => e

Library/Homebrew/cask/dsl.rb

@@ -54,7 +54,6 @@ class DSL
     ].freeze
 
     DSL_METHODS = Set.new [
-      :accessibility_access,
       :appcast,
       :artifacts,
       :auto_updates,
@@ -251,10 +250,6 @@ def caveats(*strings, &block)
       @caveats
     end
 
-    def accessibility_access(accessibility_access = nil)
-      set_unique_stanza(:accessibility_access, accessibility_access.nil?) { accessibility_access }
-    end
-
     def auto_updates(auto_updates = nil)
       set_unique_stanza(:auto_updates, auto_updates.nil?) { auto_updates }
     end

Library/Homebrew/cask/installer.rb

@@ -94,7 +94,6 @@ def install
       opoo "macOS's Gatekeeper has been disabled for this Cask" unless quarantine?
       stage
       install_artifacts
-      enable_accessibility_access
 
       unless @cask.tap&.private?
         ::Utils::Analytics.report_event("cask_install", @cask.token)
@@ -365,67 +364,6 @@ def print_caveats
       self.class.print_caveats(@cask)
     end
 
-    # TODO: logically could be in a separate class
-    def enable_accessibility_access
-      return unless @cask.accessibility_access
-
-      ohai "Enabling accessibility access"
-      if MacOS.version <= :mountain_lion
-        @command.run!(
-          "/usr/bin/touch",
-          args: [MacOS.pre_mavericks_accessibility_dotfile],
-          sudo: true,
-        )
-      elsif MacOS.version <= :yosemite
-        @command.run!(
-          "/usr/bin/sqlite3",
-          args: [
-            MacOS.tcc_db,
-            "INSERT OR REPLACE INTO access " \
-            "VALUES('kTCCServiceAccessibility','#{bundle_identifier}',0,1,1,NULL);",
-          ],
-          sudo: true,
-        )
-      elsif MacOS.version <= :el_capitan
-        @command.run!(
-          "/usr/bin/sqlite3",
-          args: [
-            MacOS.tcc_db,
-            "INSERT OR REPLACE INTO access " \
-            "VALUES('kTCCServiceAccessibility','#{bundle_identifier}',0,1,1,NULL,NULL);",
-          ],
-          sudo: true,
-        )
-      else
-        opoo <<~EOS
-          Accessibility access cannot be enabled automatically on this version of macOS.
-          See System Preferences to enable it manually.
-        EOS
-      end
-    rescue => e
-      purge_versioned_files
-      raise e
-    end
-
-    def disable_accessibility_access
-      return unless @cask.accessibility_access
-
-      if MacOS.version >= :mavericks && MacOS.version <= :el_capitan
-        ohai "Disabling accessibility access"
-        @command.run!("/usr/bin/sqlite3",
-                      args: [
-                        MacOS.tcc_db,
-                        "DELETE FROM access WHERE client='#{bundle_identifier}';",
-                      ],
-                      sudo: true)
-      else
-        opoo <<~EOS
-          Accessibility access cannot be disabled automatically on this version of macOS.
-          See System Preferences to disable it manually.
-        EOS
-      end
-    end
-
     def save_caskfile
       old_savedir = @cask.metadata_timestamped_path
 
@@ -438,7 +376,6 @@ def save_caskfile
 
     def uninstall
       oh1 "Uninstalling Cask #{Formatter.identifier(@cask)}"
-      disable_accessibility_access
       uninstall_artifacts(clear: true)
       purge_versioned_files
       purge_caskroom_path if force?
@@ -447,7 +384,6 @@ def uninstall
     def start_upgrade
       oh1 "Starting upgrade for Cask #{Formatter.identifier(@cask)}"
 
-      disable_accessibility_access
       uninstall_artifacts
       backup
     end
@@ -471,7 +407,6 @@ def revert_upgrade
       opoo "Reverting upgrade for Cask #{@cask}"
       restore_backup
       install_artifacts
-      enable_accessibility_access
     end
 
     def finalize_upgrade

Library/Homebrew/cask/staged.rb

@@ -2,29 +2,6 @@
 
 module Cask
   module Staged
-    def info_plist_file(index = 0)
-      index =  0 if index == :first
-      index =  1 if index == :second
-      index = -1 if index == :last
-      @cask.artifacts.select { |a| a.is_a?(Artifact::App) }.at(index).target.join("Contents", "Info.plist")
-    end
-
-    def plist_exec(cmd)
-      @command.run!("/usr/libexec/PlistBuddy", args: ["-c", cmd, info_plist_file])
-    end
-
-    def plist_set(key, value)
-      plist_exec("Set #{key} #{value}")
-    rescue => e
-      raise CaskError, "#{@cask.token}: 'plist_set' failed with: #{e}"
-    end
-
-    def bundle_identifier
-      plist_exec("Print CFBundleIdentifier").stdout.chomp
-    rescue => e
-      raise CaskError, "#{@cask.token}: 'bundle_identifier' failed with: #{e}"
-    end
-
     def set_permissions(paths, permissions_str)
       full_paths = remove_nonexistent(paths)
       return if full_paths.empty?

Library/Homebrew/compat/cask/dsl.rb

@@ -8,6 +8,10 @@ def gpg(*)
       def license(*)
         odisabled "the `license` stanza"
       end
+
+      def accessibility_access(*)
+        odeprecated "the `accessibility_access` stanza"
+      end
     end
 
     prepend Compat

Library/Homebrew/test/support/helper/spec/shared_examples/cask_staged.rb

@@ -21,30 +21,6 @@
     staged.system_command("echo", args: ["homebrew-cask", "rocks!"])
   end
 
-  it "can get the Info.plist file for the primary app" do
-    expect(staged.info_plist_file).to eq Cask::Config.global.appdir.join("TestCask.app/Contents/Info.plist")
-  end
-
-  it "can execute commands on the Info.plist file" do
-    allow(staged).to receive(:bundle_identifier).and_return("com.example.BasicCask")
-
-    FakeSystemCommand.expects_command(
-      ["/usr/libexec/PlistBuddy", "-c", "Print CFBundleIdentifier", staged.info_plist_file],
-    )
-
-    staged.plist_exec("Print CFBundleIdentifier")
-  end
-
-  it "can set a key in the Info.plist file" do
-    allow(staged).to receive(:bundle_identifier).and_return("com.example.BasicCask")
-
-    FakeSystemCommand.expects_command(
-      ["/usr/libexec/PlistBuddy", "-c", "Set :JVMOptions:JVMVersion 1.6+", staged.info_plist_file],
-    )
-
-    staged.plist_set(":JVMOptions:JVMVersion", "1.6+")
-  end
-
   it "can set the permissions of a file" do
     fake_pathname = existing_path
     allow(staged).to receive(:Pathname).and_return(fake_pathname)