Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More deprecated/disabled updates #5174

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions Library/Homebrew/cmd/tap.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ module Homebrew
def tap
if ARGV.include? "--repair"
Tap.each(&:link_completions_and_manpages)
elsif ARGV.include? "--list-official"
odisabled("brew tap --list-official")
elsif ARGV.include? "--list-pinned"
puts Tap.select(&:pinned?).map(&:name)
elsif ARGV.named.empty?
Expand Down
6 changes: 1 addition & 5 deletions Library/Homebrew/compat.rb
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
require "compat/os/mac"
require "compat/requirements/x11_requirement"
require "compat/requirements/xcode_requirement"
require "compat/dependable"
require "compat/dependency_collector"
require "compat/cask"
require "compat/download_strategy"
require "compat/fileutils"
require "compat/formula_support"
require "compat/cask"
require "compat/tap"
2 changes: 2 additions & 0 deletions Library/Homebrew/compat/cask/cask_loader.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ class FromPathLoader < FromContentLoader
module Compat
private

# TODO: can't delete this code until the merge of
# https://github.com/Homebrew/brew/pull/4730 or an equivalent.
def cask(header_token, **options, &block)
if header_token.is_a?(Hash) && header_token.key?(:v1)
odisabled %q("cask :v1 => 'token'"), %q("cask 'token'")
Expand Down
4 changes: 1 addition & 3 deletions Library/Homebrew/compat/cask/cmd/--version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ def initialize(*)
end

def run
odeprecated "`brew cask --version`", "`brew --version`", disable_on: Time.new(2018, 10, 31)
ARGV.clear
Homebrew.__version
odisabled "`brew cask --version`", "`brew --version`"
end

def self.help
Expand Down
13 changes: 1 addition & 12 deletions Library/Homebrew/compat/cask/cmd/cleanup.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,7 @@ def initialize(*args, cache_location: Cache.path)
end

def run
odeprecated "`brew cask cleanup`", "`brew cleanup`", disable_on: Time.new(2018, 9, 30)

cleanup = Homebrew::Cleanup.new

casks(alternative: -> { Cask.to_a }).each do |cask|
cleanup.cleanup_cask(cask)
end

return if cleanup.disk_cleanup_size.zero?

disk_space = disk_usage_readable(cleanup.disk_cleanup_size)
ohai "This operation has freed approximately #{disk_space} of disk space."
odisabled "`brew cask cleanup`", "`brew cleanup`"
end
end
end
Expand Down
3 changes: 1 addition & 2 deletions Library/Homebrew/compat/cask/cmd/search.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ class Cmd
module Compat
class Search < AbstractCommand
def run
odeprecated "`brew cask search`", "`brew search`", disable_on: Time.new(2018, 9, 30)
Homebrew.search(args.empty? ? "--casks" : args)
odisabled "`brew cask search`", "`brew search`"
end

def self.visible
Expand Down
7 changes: 5 additions & 2 deletions Library/Homebrew/compat/cask/dsl.rb
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
module Cask
class DSL
module Compat
# TODO: can't delete this code until the merge of
# https://github.com/Homebrew/brew/pull/4730 or an equivalent.

def gpg(*)
odeprecated "the `gpg` stanza", disable_on: Time.new(2018, 12, 31)
odisabled "the `gpg` stanza"
end

def license(*)
odisabled "the `license` stanza"
end

def accessibility_access(*)
odeprecated "the `accessibility_access` stanza"
odisabled "the `accessibility_access` stanza"
end
end

Expand Down
10 changes: 0 additions & 10 deletions Library/Homebrew/compat/dependable.rb

This file was deleted.

12 changes: 0 additions & 12 deletions Library/Homebrew/compat/dependency_collector.rb

This file was deleted.

12 changes: 4 additions & 8 deletions Library/Homebrew/compat/fileutils.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,12 @@

module FileUtils
module Compat
def ruby(*args)
odeprecated "ruby", 'system "ruby"'
system RUBY_PATH, *args
def ruby(*)
odisabled "ruby", 'system "ruby"'
end

def mktemp(prefix = name, opts = {})
odeprecated("FileUtils.mktemp", "mktemp")
Mktemp.new(prefix, opts).run do |staging|
yield staging
end
def mktemp(*)
odisabled("FileUtils.mktemp", "mktemp")
end
module_function :mktemp
end
Expand Down
75 changes: 0 additions & 75 deletions Library/Homebrew/compat/formula_support.rb

This file was deleted.

14 changes: 0 additions & 14 deletions Library/Homebrew/compat/os/mac.rb

This file was deleted.

1 change: 0 additions & 1 deletion Library/Homebrew/formula.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2532,7 +2532,6 @@ def cxxstdlib_check(check_type)
# version '4.8.1'
# end</pre>
def fails_with(compiler, &block)
odisabled "fails_with :llvm" if compiler == :llvm
specs.each { |spec| spec.fails_with(compiler, &block) }
end

Expand Down
4 changes: 0 additions & 4 deletions Library/Homebrew/requirement.rb
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,6 @@ class << self
attr_reader :env_proc, :build
attr_rw :fatal, :cask, :download

def default_formula(_val = nil)
odisabled "Requirement.default_formula"
end

def satisfy(options = nil, &block)
return @satisfied if options.nil? && !block_given?

Expand Down
1 change: 0 additions & 1 deletion Library/Homebrew/software_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ def patch(strip = :p1, src = nil, &block)
end

def fails_with(compiler, &block)
odisabled "fails_with :llvm" if compiler == :llvm
compiler_failures << CompilerFailure.create(compiler, &block)
end

Expand Down