Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocops: remove scons audit. #5490

Merged
merged 1 commit into from
Jan 6, 2019
Merged

rubocops: remove scons audit. #5490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions Library/Homebrew/rubocops/text.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node)
problem %q(use "xcodebuild *args" instead of "system 'xcodebuild', *args")
end

find_method_with_args(body_node, :system, "scons") do
problem "use \"scons *args\" instead of \"system 'scons', *args\""
end

find_method_with_args(body_node, :system, "go", "get") do
problem "Do not use `go get`. Please ask upstream to implement Go vendoring"
end
Expand Down
14 changes: 0 additions & 14 deletions Library/Homebrew/test/rubocops/text_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,20 +86,6 @@ def install
RUBY
end

it "When scons is executed" do
expect_offense(<<~RUBY)
class Foo < Formula
url "https://brew.sh/foo-1.0.tgz"
homepage "https://brew.sh"

def install
system "scons", "foo", "bar"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use \"scons *args\" instead of \"system 'scons', *args\"
end
end
RUBY
end

it "When plist_options are not defined when using a formula-defined plist", :ruby23 do
expect_offense(<<~RUBY)
class Foo < Formula
Expand Down