Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli_parser: Dont raise FormulaUnavailableError #5673

Merged
merged 1 commit into from
Feb 5, 2019
Merged

cli_parser: Dont raise FormulaUnavailableError #5673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions Library/Homebrew/cli_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,8 @@ def formula_options
end
end
end
rescue FormulaUnavailableError
[]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to ignore (Not raise FormualUnavailableError) this exception here. Found no alternative.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can lead to some tricky buggy cases.
What if the user passes multiple formulae names with a single invalid name ?
ARGV.formulae in that case would throw an exception and none of the formula options would get declared.
@MikeMcQuaid I think we could modify ARGV.formulae 's code to better handle this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GauthamGoli Yes, that seems like a good idea. As we discussed I think almost all of https://github.com/Homebrew/brew/blob/master/Library/Homebrew/extend/ARGV.rb would move to https://github.com/Homebrew/brew/blob/master/Library/Homebrew/cli_parser.rb instead.

end

def hide_from_man_page!
Expand Down