Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Xcode 10.2 on macOS 10.14 #6083

Merged
merged 1 commit into from May 1, 2019
Merged

Require Xcode 10.2 on macOS 10.14 #6083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Library/Homebrew/os/mac/xcode.rb
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ def latest_version

def minimum_version
case MacOS.version
when "10.14" then "10.0"
when "10.14" then "10.2"
when "10.13" then "9.0"
when "10.12" then "8.0"
else "2.0"
Expand Down
18 changes: 0 additions & 18 deletions Library/Homebrew/requirements/xcode_requirement.rb
View file
Open in desktop
Expand Up @@ -14,7 +14,6 @@ def initialize(tags = [])

def xcode_installed_version
return false unless MacOS::Xcode.installed?
return false unless xcode_swift_compatability?
return true unless @version

MacOS::Xcode.version >= @version
Expand All @@ -26,12 +25,6 @@ def message
A full installation of Xcode.app#{version} is required to compile
this software. Installing just the Command Line Tools is not sufficient.
EOS
unless xcode_swift_compatability?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compatibility

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing I deleted it 😆

message += <<~EOS

Xcode >=10.2 requires macOS >=10.14.4 to build many formulae.
EOS
end
if @version && Version.new(MacOS::Xcode.latest_version) < Version.new(@version)
message + <<~EOS

Expand All @@ -49,15 +42,4 @@ def message
def inspect
"#<#{self.class.name}: #{tags.inspect} version=#{@version.inspect}>"
end

private

# TODO: when 10.14.4 and 10.2 have been around for long enough remove this
# method in favour of requiring 10.14.4 and 10.2.
def xcode_swift_compatability?
return true if MacOS::Xcode.version < "10.2"
return true if MacOS.full_version >= "10.14.4"

MacOS.full_version < "10.14"
end
end