Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AppleScript to check if GUI apps are running. #6457

Merged
merged 1 commit into from Sep 16, 2019
Merged

Use AppleScript to check if GUI apps are running. #6457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
35 changes: 28 additions & 7 deletions Library/Homebrew/cask/artifact/abstract_uninstall.rb
View file
Open in desktop
Expand Up @@ -127,7 +127,7 @@ def running_processes(bundle_id)
# :quit/:signal must come before :kext so the kext will not be in use by a running process
def uninstall_quit(*bundle_ids, command: nil, **_)
bundle_ids.each do |bundle_id|
next if running_processes(bundle_id).empty?
next unless running?(bundle_id)

unless User.current.gui?
opoo "Not logged into a GUI; skipping quitting application ID '#{bundle_id}'."
Expand All @@ -146,10 +146,10 @@ def uninstall_quit(*bundle_ids, command: nil, **_)
Kernel.loop do
next unless quit(bundle_id).success?

if running_processes(bundle_id).empty?
puts "Application '#{bundle_id}' quit successfully."
break
end
next if running?(bundle_id)

puts "Application '#{bundle_id}' quit successfully."
break
end
end
rescue Timeout::Error
Expand All @@ -159,6 +159,28 @@ def uninstall_quit(*bundle_ids, command: nil, **_)
end
end

def running?(bundle_id)
script = <<~JAVASCRIPT
'use strict';

ObjC.import('stdlib')

function run(argv) {
try {
var app = Application(argv[0])
if (app.running()) {
$.exit(0)
}
} catch (err) { }

$.exit(1)
}
JAVASCRIPT

system_command("osascript", args: ["-l", "JavaScript", "-e", script, bundle_id],
print_stderr: true).status.success?
end

def quit(bundle_id)
script = <<~JAVASCRIPT
'use strict';
Expand All @@ -181,8 +203,7 @@ def quit(bundle_id)
JAVASCRIPT

system_command "osascript", args: ["-l", "JavaScript", "-e", script, bundle_id],
print_stderr: false,
sudo: true
print_stderr: false
end
private :quit

Expand Down
10 changes: 5 additions & 5 deletions Library/Homebrew/test/cask/artifact/shared_examples/uninstall_zap.rb
View file
Open in desktop
Expand Up @@ -119,7 +119,7 @@
it "is skipped when the user does not have automation access" do
allow(User).to receive(:automation_access?).and_return false
allow(User.current).to receive(:gui?).and_return true
allow(subject).to receive(:running_processes).with(bundle_id).and_return([[0, "", bundle_id]])
allow(subject).to receive(:running?).with(bundle_id).and_return(true)

expect {
subject.public_send(:"#{artifact_dsl_key}_phase", command: fake_system_command)
Expand All @@ -128,7 +128,7 @@

it "is skipped when the user is not a GUI user" do
allow(User.current).to receive(:gui?).and_return false
allow(subject).to receive(:running_processes).with(bundle_id).and_return([[0, "", bundle_id]])
allow(subject).to receive(:running?).with(bundle_id).and_return(true)

expect {
subject.public_send(:"#{artifact_dsl_key}_phase", command: fake_system_command)
Expand All @@ -139,10 +139,10 @@
allow(User).to receive(:automation_access?).and_return true
allow(User.current).to receive(:gui?).and_return true

expect(subject).to receive(:running_processes).with(bundle_id).ordered.and_return([[0, "", bundle_id]])
expect(subject).to receive(:running?).with(bundle_id).ordered.and_return(true)
expect(subject).to receive(:quit).with(bundle_id)
.and_return(instance_double("SystemCommand::Result", success?: true))
expect(subject).to receive(:running_processes).with(bundle_id).ordered.and_return([])
expect(subject).to receive(:running?).with(bundle_id).ordered.and_return(false)

expect {
subject.public_send(:"#{artifact_dsl_key}_phase", command: fake_system_command)
Expand All @@ -153,7 +153,7 @@
allow(User).to receive(:automation_access?).and_return true
allow(User.current).to receive(:gui?).and_return true

allow(subject).to receive(:running_processes).with(bundle_id).and_return([[0, "", bundle_id]])
allow(subject).to receive(:running?).with(bundle_id).and_return(true)
allow(subject).to receive(:quit).with(bundle_id)
.and_return(instance_double("SystemCommand::Result", success?: false))

Expand Down