Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundle dump fails when ZDOTDIR defined #6533

Closed
davidosomething opened this issue Oct 3, 2019 · 4 comments
Closed

bundle dump fails when ZDOTDIR defined #6533

davidosomething opened this issue Oct 3, 2019 · 4 comments
Labels
outdated PR was locked due to age

Comments

@davidosomething
Copy link
Contributor 

 I  (master)% b bundle dump --force
Error: No such file or directory @ rb_sysopen - /Users/davidosomething/.zshrc

 I  (master)% touch ~/.zshrc

 I  (master)% b bundle dump --force

(success)

When $ZDOTDIR is defined in .zshenv, allowing user to place .zshrc in a different directory from .zshenv, brew bundle dump fails. The ruby syscall always tries to open .zshrc from $HOME. Creating a temporary .zshrc in $HOME is a workaround.
@MikeMcQuaid
Copy link
Member

You'll need to address this yourself, we don't do anything with zsh.

@davidosomething
Copy link
Contributor Author

davidosomething commented Oct 5, 2019 •
edited

Homebrew/brew does do stuff with shells -- it's that the RC file path is hardcoded here:

brew/Library/Homebrew/utils/shell.rb

Line 75 in 9a6d7dd

zsh: "~/.zshrc",

To be correct, it should defer to zsh's settings, which is $ZDOTDIR/.zshrc
http://zsh.sourceforge.net/Intro/intro_3.html

The issue arises when referencing the shell_profile util, e.g. when using a tapped formula like this
https://github.com/Schniz/homebrew-tap/blob/master/Formula/fnm.rb#L21
shell_profile is wrong because it does not support zsh environment variables.

@MikeMcQuaid
Copy link
Member

Ok. We'll review a PR to add that functionality.

davidosomething added a commit to davidosomething/brew that referenced this issue Oct 6, 2019
@davidosomething
Support for zsh ZDOTDIR, FIX Homebrew#6533
960b8b6 
- Add test spec with ZDOTDIR set and unset
@davidosomething davidosomething mentioned this issue Oct 6, 2019
Merged
6 tasks
@davidosomething
Copy link
Contributor Author

@MikeMcQuaid I gave it a shot, but not sure what's going on with the gh actions

MikeMcQuaid added a commit that referenced this issue Oct 8, 2019
@MikeMcQuaid
Merge pull request #6540 from davidosomething/support-zdotdir
59e3cc7 
Fix #6533 - Add support for zsh ZDOTDIR
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MikeMcQuaid @davidosomething