Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stupid mistake in 6ff61909a91edf3f31adc608dcafd3f5f8e642d0 #6627

Merged
merged 3 commits into from Oct 22, 2019
Merged

Fix stupid mistake in 6ff61909a91edf3f31adc608dcafd3f5f8e642d0 #6627

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b58931
Fix stupid mistake in 6ff61909a91edf3f31adc608dcafd3f5f8e642d0
DavidGriffith Oct 22, 2019
11f322b
Trying this to please brew test-bot.
DavidGriffith Oct 22, 2019
d15edf7
extend/string: use unless to fix style.
MikeMcQuaid Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Library/Homebrew/extend/string.rb
View file
Open in desktop
Expand Up @@ -50,7 +50,7 @@ def change_make_var!(flag, new_value)
def remove_make_var!(flags)
Array(flags).each do |flag|
# Also remove trailing \n, if present.
if gsub!(/^#{Regexp.escape(flag)}[ \t]*[\\?\+\:\!]?=.*$\n?/, "", false)
unless gsub!(/^#{Regexp.escape(flag)}[ \t]*[\\?\+\:\!]?=.*$\n?/, "", false)
errors << "expected to remove #{flag.inspect}"
end
end
Expand Down