Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: add --unsafe-perm to std_args #7089

Merged
merged 3 commits into from Mar 2, 2020
Merged

node: add --unsafe-perm to std_args #7089

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6874c79
node: add --unsafe-perm to std_args
dawidd6 Feb 28, 2020
79a1500
node: add --unsafe-perm to std_args only if run as root
dawidd6 Feb 28, 2020
aac200a
node: detect root via Process.uid
dawidd6 Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion Library/Homebrew/language/node.rb
View file
Open in desktop
Expand Up @@ -41,14 +41,18 @@ def self.std_npm_install_args(libexec)
pack = pack_for_installation

# npm install args for global style module format installed into libexec
%W[
args = %W[
-ddd
--global
--build-from-source
--#{npm_cache_config}
--prefix=#{libexec}
#{Dir.pwd}/#{pack}
]

args << "--unsafe-perm" if Process.uid.zero?

args
end

def self.local_npm_install_args
Expand Down